Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and disable app parts #613

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

kostobog
Copy link
Collaborator

Copy link
Contributor

@blcham blcham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment. Wouldn't be more readable/understandable to have:

ENVVariable.ENABLE_FMEA with default true?

path: ROUTES.FMEA,
element: <FmeaOverview />,
},
{
!ENVVariable.DISABLE_FMEA && {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this can work correctly:

image

@blcham blcham self-requested a review October 3, 2024 09:05
@blcham blcham force-pushed the fix/603-remove-and-disable-app-parts branch from 9bcb259 to 968c098 Compare October 3, 2024 09:06
@blcham blcham merged commit 77454fd into main Oct 3, 2024
1 check passed
@blcham blcham deleted the fix/603-remove-and-disable-app-parts branch October 3, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove or disable parts that does not work
2 participants